Skip to content

Conversation

@ryanohnemus
Copy link
Contributor

@ryanohnemus ryanohnemus commented Aug 1, 2024

The http client connection used to watch (stream) k8s events from the kube api server could deadlock the kubernetes_events plugin if the k8s api server ends the connection with a standard end of chunked stream instead of a different connection closure that would result in the http client returning an FLB_HTTP_ERROR. This same deadlock can also occur if there is a http client connection initialization error.

In either scenario the ctx->streaming_client and ctx->current_connection do not get cleaned up, which results in the next coro being deadlocked because we did not unlock pthread_mutex_unlock(&ctx->lock); (after obtaining the lock and checking if the streaming_client already exists.)


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

Signed-off-by: ryanohnemus <ryanohnemus@gmail.com>
@ryanohnemus ryanohnemus force-pushed the in_k8s_events_end_of_stream branch from 73e2dc2 to aa61aed Compare August 1, 2024 19:36
@ryanohnemus ryanohnemus force-pushed the in_k8s_events_end_of_stream branch from aa61aed to feb92e4 Compare August 1, 2024 21:32
Signed-off-by: ryanohnemus <ryanohnemus@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants